Only treat 'bin'/'obj' as build artifact path segments and add related test#27
Merged
sharpninja merged 1 commit intomainfrom Mar 10, 2026
Merged
Only treat 'bin'/'obj' as build artifact path segments and add related test#27sharpninja merged 1 commit intomainfrom
sharpninja merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
bin/objwith a new helperIsBuildArtifactPath(string relativePath)that splits the relative path into segments and matches segments case-insensitively.relativePathviaPath.GetRelativePath(dir, path)and use it to decide whether a file is in abin/objsegment; retain existing exclusions for hidden files andmcp.db.src/McpServer.Services/Ingestion/RepoIngestor.csandsrc/McpServer.Support.Mcp/Ingestion/RepoIngestor.csand add a unit test intests/McpServer.Support.Mcp.Tests/Ingestion/RepoIngestorTests.cs.Testing
IngestAsync_DoesNotSkipPathsThatContainBinOrObjAsSubstringand adjustedIngestAsync_SkipsLargeFilesto run under the test harness.dotnet testfor theMcpServer.Support.Mcp.Testsproject and the tests completed successfully.IngestAsync_ContentHash_DeterministicForSameContentalso passed.Codex Task